Skip to content

Note on setting spack packages version#1157

Merged
atteggiani merged 8 commits into
developmentfrom
987-attempt_2
Mar 11, 2026
Merged

Note on setting spack packages version#1157
atteggiani merged 8 commits into
developmentfrom
987-attempt_2

Conversation

@anton-seaice

Copy link
Copy Markdown
Contributor

Closes #987

This adds a step to spack develop instructions to set the access-spack-packages version based on the most recent model release.

@anton-seaice

Copy link
Copy Markdown
Contributor Author

I made a new PR to replace #1064 - thoughts @aidanheerdegen @harshula ?

@anton-seaice anton-seaice marked this pull request as ready for review March 3, 2026 02:48
@anton-seaice anton-seaice requested a review from a team as a code owner March 3, 2026 02:48

@aidanheerdegen aidanheerdegen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Small typo. Seems fine otherwise, but note that what is written it is pretty much immediately obsolete with spack 1.1.

Comment thread docs/models/build_a_model/build_source_code.md Outdated
@anton-seaice

anton-seaice commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks.

Small typo. Seems fine otherwise, but note that what is written it is pretty much immediately obsolete with spack 1.1.

Why is that ? - i ran the same command on spack 1.1, it worked fine

@anton-seaice

anton-seaice commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

spack 1.1 checks it out from a branch:

https://github.com/ACCESS-NRI/spack-config/blob/69f94856c644814e7a9bfe990c87f0f1fa320551/common-api-v2/repos.yaml#L5

rather than the user manually checking out access-spack-packages

but spack 1.1 doesn't set the spack packages version for the user

@aidanheerdegen

Copy link
Copy Markdown
Member

Why is that ? - i ran the same command on spack 1.1, it worked fine

Ah right. Well the documentation says the options is --tags, but it seems --tag is supported (though undocumented in the man page). I'd say it should be changed to the option specified in the docs.

@aidanheerdegen

Copy link
Copy Markdown
Member

but spack 1.1 doesn't set the spack packages version for the user

Good point. I was wrong. And with the change @harshula made to expose accesss-pack-packages I guess it pretty much does function as before.

So I'll approve, but should get Harshula's opinion.

aidanheerdegen
aidanheerdegen previously approved these changes Mar 3, 2026
@anton-seaice

Copy link
Copy Markdown
Contributor Author

Why is that ? - i ran the same command on spack 1.1, it worked fine

Ah right. Well the documentation says the options is --tags, but it seems --tag is supported (though undocumented in the man page). I'd say it should be changed to the option specified in the docs.

Oh yes - this part is fine. Ill apply it

@anton-seaice anton-seaice requested a review from harshula March 3, 2026 04:56
@anton-seaice anton-seaice self-assigned this Mar 3, 2026
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
@harshula

harshula commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

This PR should wait for PR #1154 to be merged.

Comment thread docs/models/build_a_model/build_source_code.md Outdated
@anton-seaice

Copy link
Copy Markdown
Contributor Author

Thanks Harshula - will mark as draft until #1154

@anton-seaice anton-seaice marked this pull request as draft March 3, 2026 21:49
@anton-seaice anton-seaice marked this pull request as ready for review March 11, 2026 04:12
@anton-seaice

Copy link
Copy Markdown
Contributor Author

Thanks @harshula - ready for review

@anton-seaice anton-seaice requested a review from harshula March 11, 2026 04:12
Comment thread docs/models/build_a_model/build_source_code.md Outdated
Comment thread docs/models/build_a_model/build_source_code.md Outdated
@anton-seaice anton-seaice requested a review from harshula March 11, 2026 21:46
@anton-seaice

Copy link
Copy Markdown
Contributor Author

@ACCESS-NRI/hivedocsteam - ready for final review

@atteggiani

Copy link
Copy Markdown
Contributor

This PR should wait for PR #1154 to be merged.

Is this still relevant?

@atteggiani atteggiani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@anton-seaice

Copy link
Copy Markdown
Contributor Author

This PR should wait for PR #1154 to be merged.

Is this still relevant?

We've switched the order, we'll do this PR first and @harshula can update for spack 1.1 in #1154

@harshula harshula left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anton-seaice

Copy link
Copy Markdown
Contributor Author

Could you merge please @atteggiani

@harshula

Copy link
Copy Markdown
Contributor

Please ensure these commits are squashed ...

@atteggiani atteggiani merged commit 706699c into development Mar 11, 2026
36 of 37 checks passed
@atteggiani atteggiani deleted the 987-attempt_2 branch March 11, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add note about spack-packages version to " Modify and build an ACCESS model's source code "

4 participants