Skip to content

Restore tob Kelvin conversion#488

Merged
rbeucher merged 6 commits into
mainfrom
fix/remove-tob-kelvin
Jul 8, 2026
Merged

Restore tob Kelvin conversion#488
rbeucher merged 6 commits into
mainfrom
fix/remove-tob-kelvin

Conversation

@rbeucher

@rbeucher rbeucher commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

  • restore the kelvin_to_celsius wrapper for the ACCESS-ESM1-6 tob mapping
  • keep tob as kelvin_to_celsius(ocean_floor(pot_temp))
  • retain the guarded Kelvin conversion fallback used by the helper

Validation

  • pixi run -e dev python -m pytest tests/unit/test_derivations.py -q
  • pixi run -e dev python -m coverage run -m pytest tests/unit/test_derivations.py -q && pixi run -e dev python -m coverage report -m src/access_moppy/derivations/__init__.py

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.7%. Comparing base (b5e3948) to head (959e86c).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #488     +/-   ##
=======================================
+ Coverage   78.6%   78.7%   +0.1%     
=======================================
  Files         33      33             
  Lines       6534    6548     +14     
  Branches    1235    1239      +4     
=======================================
+ Hits        5135    5153     +18     
+ Misses      1129    1127      -2     
+ Partials     270     268      -2     
Flag Coverage Δ
unit 78.7% <100.0%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rbeucher rbeucher changed the title Remove kelvin_to_celsius from tob mapping Restore tob Kelvin conversion Jul 8, 2026
@rbeucher
rbeucher merged commit 42747c9 into main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant