fix fx/static resampling path for mrsofc#494
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=====================================
Coverage 78.7% 78.7%
=====================================
Files 33 33
Lines 6548 6557 +9
Branches 1239 1242 +3
=====================================
+ Hits 5153 5162 +9
Misses 1127 1127
Partials 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this does
this fixes the fx/static path so we do not try to do temporal resampling logic on time-invariant targets.
changes
validate_and_resample_if_needed()timecoordinate or a singletontimeIncompatibleFrequencyErrorif an fx target gets truly time-varying inputtests/unit/test_temporal_resampling.pyfor these caseswhy
we hit a failure in the cmip7 land integration case (
mrsofc) where the pipeline reached resampling validation for an fx variable and blew up on time-frequency handling.