Skip to content

Fix false CMIP7 QC failures at closed-range boundaries#495

Merged
rbeucher merged 2 commits into
mainfrom
fix/cmip7-qc-boundary-tolerance
Jul 8, 2026
Merged

Fix false CMIP7 QC failures at closed-range boundaries#495
rbeucher merged 2 commits into
mainfrom
fix/cmip7-qc-boundary-tolerance

Conversation

@rbeucher

@rbeucher rbeucher commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

  • make CMIP7 range checks use a scale-aware float tolerance for closed-interval comparisons
  • avoid false failures when boundary values (for example 100%) round slightly outside limits in float32-derived outputs
  • add a regression test for snc with near-boundary percent values

Testing

  • pixi run -e dev python -m pytest tests/unit/test_cmip7_qc.py -k "tiny_negative_noise_at_zero_bound or float32_boundary_noise_for_percent_range or tas_fails_for_picontrol_range" -q

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.7%. Comparing base (24d23cc) to head (fbda862).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #495   +/-   ##
=====================================
  Coverage   78.7%   78.7%           
=====================================
  Files         33      33           
  Lines       6548    6558   +10     
  Branches    1239    1242    +3     
=====================================
+ Hits        5153    5163   +10     
  Misses      1127    1127           
  Partials     268     268           
Flag Coverage Δ
unit 78.7% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rbeucher
rbeucher merged commit a8d360d into main Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant