Fix 3hr and 6hr issue#497
Merged
Merged
Conversation
rbeucher
force-pushed
the
fix/fix_3hr_6hr_issue
branch
from
July 9, 2026 09:21
ba6e319 to
d592338
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (60.0%) is below the target coverage (90.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
=======================================
- Coverage 78.7% 78.7% -0.0%
=======================================
Files 33 33
Lines 6558 6574 +16
Branches 1242 1245 +3
=======================================
+ Hits 5163 5173 +10
- Misses 1127 1131 +4
- Partials 268 270 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the handling of time dimensions, sub-daily point-sampled data, and CMIP table support in the ACCESS-MOPPY codebase. The main focus is on ensuring WCRP TIME001 compliance for sub-daily outputs, improving flexibility for time axis handling, and adding support for additional CMIP tables. Below are the most important changes:
Time Dimension Handling and Compliance
load_datasetand_preprocessto canonicalize UM auxiliary time dimensions (time_0,time_1) to a single"time"axis, ensuring that only the relevant time axis is kept and others are dropped. This prevents issues with dimension inflation and improves dataset consistency."time"rather than just"time", making the code more robust for datasets with multiple or nonstandard time axes. [1] [2]Sub-daily Point-sampled Data Alignment
_align_subdaily_point_time_to_square_gridmethod to automatically shift sub-daily point-sampled time axes (e.g., those starting at 03:00 or 06:00) to align with canonical daily grid boundaries, as required by WCRP TIME001. This alignment is now invoked automatically before writing output. [1] [2]CMIP Table and Frequency Support
"3hrPt"and"6hrPlevPt"CMIP tables throughout the codebase, including in the driver initialization, error messages, and frequency parsing. [1] [2] [3]Example Configuration
seaIce.ts.tavg-u-hxy-si.mon.glb), clarifying expected mappings.