Always set minimum depth when using topog for masks#138
Merged
Conversation
Contributor
Author
|
You might be interested @claireyung |
dougiesquire
previously approved these changes
Jun 29, 2026
dougiesquire
left a comment
dougiesquire
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @anton-seaice. I always find the MINIMUM_DEPTH and MASKING_DEPTH params very confusing.
Contributor
Author
|
I missed the tidal generation files, will revisit after #140 |
Contributor
Author
|
For whatever reasion, minimum_depth and masking_depth aren't set in tidal generation scrips, so ill leave them alone |
Contributor
Author
|
It appears bottom roughness files don't have a mask in them: 
so if there are a few extra cells which have roughness calculated which aren't used, I guess it's fine |
Contributor
Author
|
Example output in /g/data/tm70/as2285/making_inputs/om3-scripts/rof_pattern_generation/rofi_test.nc |
dougiesquire
approved these changes
Jul 3, 2026
dougiesquire
left a comment
dougiesquire
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @anton-seaice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129
This always sets the minimum depth to the MOM default value when making land/sea masks