Harmonise metadata creation#140
Merged
Merged
Conversation
Contributor
Author
|
Ready to go @dougiesquire |
dougiesquire
requested changes
Jun 30, 2026
dougiesquire
left a comment
dougiesquire
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @anton-seaice. Some scripts are broken, see below. I'd definitely feel more comfortable if we'd verified all scripts work and don't lose any provenance info.
anton-seaice
commented
Jun 30, 2026
anton-seaice
left a comment
anton-seaice
left a comment
Contributor
Author
There was a problem hiding this comment.
Don't look yet, will finish tomorrow
anton-seaice
commented
Jul 1, 2026
anton-seaice
left a comment
anton-seaice
left a comment
Contributor
Author
There was a problem hiding this comment.
Still don't look yet
anton-seaice
commented
Jul 1, 2026
anton-seaice
left a comment
anton-seaice
left a comment
Contributor
Author
There was a problem hiding this comment.
I ran all the commonly generated input files
dougiesquire
approved these changes
Jul 2, 2026
dougiesquire
left a comment
dougiesquire
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @anton-seaice - looks good
dougiesquire
reviewed
Jul 2, 2026
Contributor
Author
|
Try again @dougiesquire |
dougiesquire
reviewed
Jul 3, 2026
dougiesquire
approved these changes
Jul 3, 2026
dougiesquire
left a comment
dougiesquire
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @anton-seaice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139
This change updates
get_provenance_metadatato generate runcmd automatically, and to include information on input files.get_provenance_metadata now returns a dictionary
Spot checked some metadata:
drof.streams.xml:
<history>Created by as2285 (anton-seaice) on 2026-06-30, using https://github.com/ACCESS-NRI/om3-scripts/blob/07bb1ec4762068a6d522f9b44a393452e7aafa57/generate_xml_drof_jra55.py: /g/data/xp65/public/apps/med_conda_scripts/analysis3-26.05.d/bin/python3 generate_xml_drof_jra55.py 1900 1900</history>mesh:
history = "Created by as2285 (anton-seaice) on 2026-06-30, using https://github.com/ACCESS-NRI/om3-scripts/blob/07bb1ec4762068a6d522f9b44a393452e7aafa57/generate_rof_weights.py: /g/data/xp65/public/apps/med_conda_scripts/analysis3-26.05.d/bin/python3 generate_rof_weights.py --mesh_filename=/g/data/tm70/ek4684/make_OM3_025deg_topo_26_11_25/access-om3-100km-ESMFmesh.nc --nx=360 --ny=324 --weights_filename=test_weights.nc"