Skip to content

Add build-ci#5

Open
CodeGat wants to merge 1 commit into
access/v1.1from
1-build-ci
Open

Add build-ci#5
CodeGat wants to merge 1 commit into
access/v1.1from
1-build-ci

Conversation

@CodeGat

@CodeGat CodeGat commented Jul 2, 2026

Copy link
Copy Markdown
Member

Closes #1

Background

Similarly to ACCESS-NRI/access-spack-packages#420 and ACCESS-NRI/spack-config#95, we are adding build-ci to upstream-spack-packages so we can test changes to the builtin set of packages by building our software and models on top of it.

The PR

  • Add .github/workflows/build-ci.yml similarly to the above PRs

Testing

See https://github.com/ACCESS-NRI/upstream-spack-packages/actions/runs/28643009154?pr=5

@CodeGat CodeGat added the enhancement New feature or request label Jul 2, 2026
@CodeGat CodeGat self-assigned this Jul 2, 2026
@CodeGat CodeGat force-pushed the 1-build-ci branch 3 times, most recently from 5ef9a05 to 9138251 Compare July 3, 2026 06:21
@CodeGat CodeGat marked this pull request as ready for review July 6, 2026 00:24
@CodeGat

CodeGat commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Noting that the failures are the same as the ones from access-spack-packages.

@CodeGat CodeGat requested a review from harshula July 6, 2026 06:48

@aidanheerdegen aidanheerdegen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the whole scheme of things pretty neat how compact this is considering how much it is doing. Nice!

pull_request:
branches:
# We only want to run our CI on pull requests to the access/** branches
- 'access/**'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the branch protections for creating access/** branches? Does it match this?

Comment on lines +126 to +136
- manifest: {template_value: "access-om2"}
- manifest: {template_value: "access-om2-bgc"}
- manifest: {template_value: "access-om3"}
- manifest: {template_value: "access-esm1p5"}
- manifest: {template_value: "access-esm1p6"}
- manifest: {template_value: "access-am3"}
- manifest: {template_value: "access-ram3"}
- manifest: {template_value: "access-issm"}
- manifest: {template_value: "access-test"}
- manifest: {template_value: "coastri-roms"}
- manifest: {template_value: "gcom4"}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CodeGat , Can we centralise the exclude list only in the access-spack-packages repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants