Add fuzz tests for Bolt11 and Bolt12 deserialization#3292
Open
NishantBansal2003 wants to merge 2 commits intoACINQ:masterfrom
Open
Add fuzz tests for Bolt11 and Bolt12 deserialization#3292NishantBansal2003 wants to merge 2 commits intoACINQ:masterfrom
NishantBansal2003 wants to merge 2 commits intoACINQ:masterfrom
Conversation
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, I am adding fuzz tests for BOLT 11 invoice deserialization, BOLT 12 offers, BOLT 12 invoice requests, BOLT 12 invoice deserialization, and minimal BOLT 12 invoice deserialization.
In the BOLT 11 fuzz tests, I normalize the input and then compare the second and third roundtrips due to an existing bug. In contrast, for the BOLT 12 tests, I perform direct roundtrip comparisons. The main objective is to ensure that eclair can handle all types of invoice data without crashing or exhibiting unintended behavior on malformed inputs.
For some of the BOLT 12 fuzz tests, I have included seed inputs (for offers, invoice requests, and invoices), since the fuzzer initially struggled to generate valid inputs. This should help the fuzzer learn more effectively and make further progress.
Also, in these fuzz tests, I am performing some initial mutations on the fuzz inputs to help generate valid invoices, since it would otherwise be quite difficult for the fuzzer to produce valid inputs and reach deeper code paths.