Use official splice messages#768
Merged
Merged
Conversation
t-bast
force-pushed
the
splicing-official
branch
from
29d8ae8 to
c80d77f
Compare
t-bast
force-pushed
the
splicing-official
branch
from
c80d77f to
9cc3a6a
Compare
We replace our experimental version of `splice_init`, `splice_ack` and `splice_locked` by their official version. We also change the TLV fields added to `commit_sig`, `tx_add_input`, and `tx_signatures` to match the spec version. We only allow connecting to peers who support the official splicing feature.
With splicing, we introduce new TLVs to `channel_reestablish` to let our peer know: - the latest `splice_locked` (or `channel_ready`) we're ready to send or have sent before disconnecting - whether we need a retransmission of `commit_sig` for the next funding - whether we need a retransmission of `announcement_signatures` for the next funding (always false for mobile wallets) This lets us clean-up retransmission of those messages and follow the official splicing spec.
When we receive the initial `channel_ready`, we update the remote funding status to be consistent with our reestablish behavior, where we would update it when receiving `my_current_funding_locked`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace our experimental version of
splice_init,splice_ackandsplice_lockedby their official version. We also change the TLV fields added tocommit_sig,tx_add_input, andtx_signaturesto match the spec version and introduce thestart_batchmessage.We also implement the updated retransmission logic for
channel_readyandsplice_lockedbased on themy_current_funding_lockedandnext_fundingTLVs added tochannel_reestablish.We only allow connecting to peers who support the official splicing feature.
This update should be released after deploying ACINQ/eclair#2887. Once enough users have upgraded, we'll be able to remove support from the legacy splicing protocol from
eclair, which will provide a nice code clean-up.