Skip to content

Commit 45ee465

Browse files
committed
Update gradle version
Fixed a few warning in the gradle file, and moved android test to unit test folder.
1 parent 3f3db8b commit 45ee465

5 files changed

Lines changed: 14 additions & 27 deletions

File tree

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ playservices = "18.9.0"
3939
junit = "4.13.2"
4040
espresso = "3.7.0"
4141
robolectric = "4.13"
42-
agp = "8.12.3"
42+
agp = "8.13.2"
4343

4444
[libraries]
4545
agp = { module = "com.android.tools.build:gradle", version.ref = "agp" }

gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.4-all.zip

phoenix-android/build.gradle.kts

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
12
import java.io.ByteArrayOutputStream
23

34
plugins {
@@ -8,14 +9,8 @@ plugins {
89
alias(libs.plugins.compose)
910
}
1011

11-
fun gitCommitHash(): String {
12-
val stream = ByteArrayOutputStream()
13-
project.exec {
14-
commandLine = "git rev-parse --verify --short HEAD".split(" ")
15-
standardOutput = stream
16-
}
17-
return String(stream.toByteArray()).split("\n").first()
18-
}
12+
fun gitCommitHash(): String = providers.exec { commandLine("git", "rev-parse", "--verify", "--short", "HEAD") }
13+
.standardOutput.asText.get().trim()
1914

2015
val chain: String by project
2116

@@ -66,11 +61,6 @@ android {
6661
targetCompatibility = JavaVersion.VERSION_1_8
6762
}
6863

69-
kotlinOptions {
70-
jvmTarget = "1.8"
71-
freeCompilerArgs = freeCompilerArgs + "-opt-in=androidx.constraintlayout.compose.ExperimentalMotionApi"
72-
}
73-
7464
buildFeatures {
7565
compose = true
7666
viewBinding = true
@@ -84,6 +74,10 @@ android {
8474
}
8575

8676
kotlin {
77+
compilerOptions {
78+
jvmTarget = JvmTarget.fromTarget("1.8")
79+
freeCompilerArgs.add("-opt-in=androidx.constraintlayout.compose.ExperimentalMotionApi")
80+
}
8781
target {
8882
compilerOptions {
8983
optIn.addAll("kotlin.RequiresOptIn")

phoenix-android/src/androidTest/kotlin/fr/acinq/phoenix/utils/AmountFormatterTest.kt renamed to phoenix-android/src/test/kotlin/fr/acinq/phoenix/utils/AmountFormatterTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
package fr.acinq.phoenix.utils
1818

1919
import fr.acinq.lightning.utils.msat
20-
import fr.acinq.phoenix.android.utils.converters.AmountFormatter.toMilliSatoshi
20+
import fr.acinq.phoenix.android.utils.converters.AmountConverter.toMilliSatoshi
2121
import fr.acinq.phoenix.data.BitcoinUnit
22-
import junit.framework.Assert.assertEquals
22+
import junit.framework.TestCase.assertEquals
2323
import org.junit.Test
2424

25-
class AmountFormatterTest {
25+
class AmountConverterTest {
2626
@Test
2727
fun test_double_to_msat_rounding() {
2828
// 1 msat

phoenix-shared/build.gradle.kts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,8 @@ plugins {
1414

1515
val includeAndroid = System.getProperty("includeAndroid")?.toBoolean() ?: false
1616

17-
/** Get the current git commit hash. */
18-
fun gitCommitHash(): String {
19-
val stream = ByteArrayOutputStream()
20-
project.exec {
21-
commandLine = "git rev-parse --verify --long HEAD".split(" ")
22-
standardOutput = stream
23-
}
24-
return String(stream.toByteArray()).split("\n").first()
25-
}
17+
fun gitCommitHash(): String = providers.exec { commandLine("git", "rev-parse", "--verify", "--short", "HEAD") }
18+
.standardOutput.asText.get().trim()
2619

2720
/**
2821
* Generates a `BuildVersions` file in phoenix-shared/build/generated-src containing the current git commit and the lightning-kmp version.

0 commit comments

Comments
 (0)