Skip to content

refactor: abstract ComfyUI boundary into core/platform.py for MuseTalk#129

Closed
AEmotionStudio wants to merge 1 commit into
refactor/platform-abstractionfrom
refactor/platform-abstraction-5686291316310126804
Closed

refactor: abstract ComfyUI boundary into core/platform.py for MuseTalk#129
AEmotionStudio wants to merge 1 commit into
refactor/platform-abstractionfrom
refactor/platform-abstraction-5686291316310126804

Conversation

@AEmotionStudio

Copy link
Copy Markdown
Owner

Extends the platform abstraction introduced in core/platform.py to cover core/musetalk/unet.py and core/musetalk_synthesizer.py.

  • Replaces direct usage of comfy.utils.load_torch_file with core.platform.load_torch_file.
  • Replaces manual paths logic to ComfyUI models with core.platform.get_models_dir.
  • Fixes ..model_manager to .model_manager import in core/musetalk_synthesizer.py since model_manager.py is in the same directory.

PR created automatically by Jules for task 5686291316310126804 started by @AEmotionStudio

Extends the platform abstraction introduced in `core/platform.py` to cover `core/musetalk/unet.py` and `core/musetalk_synthesizer.py`.
- Replaces direct usage of `comfy.utils.load_torch_file` with `core.platform.load_torch_file`.
- Replaces manual paths logic to ComfyUI models with `core.platform.get_models_dir`.
- Fixes `..model_manager` to `.model_manager` import in `core/musetalk_synthesizer.py` since `model_manager.py` is in the same directory.

Co-authored-by: AEmotionStudio <163354043+AEmotionStudio@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@AEmotionStudio AEmotionStudio deleted the refactor/platform-abstraction-5686291316310126804 branch March 2, 2026 21:42
@github-actions

github-actions Bot commented Mar 2, 2026

Copy link
Copy Markdown

⏱️ Watchdog timed out

Jules session did not complete within 30 minutes.

View session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant