🐛 Watchdog: [HIGH] Fix failing integration test asserting extremely short video speed changes#132
Conversation
…hort video speed changes The test suite generated a 0.2s test video for integration testing which, when subjected to a 2x temporal speedup, could still report a 0.2s duration from ffprobe due to container padding and minimal frame counts. This caused persistent AssertionError failures in the CI pipelines (`assert 0.2 < 0.2`). This commit: - Updates the dynamically generated test video (`_generated_video` fixture) to be 1.0 seconds long (25 frames instead of 5), ensuring temporal modifications create an observable duration shift. - Adjusts assertions in `TestSingleSkill.test_speed` and `TestMultiSkillPipeline.test_trim_resize_brightness` to correctly reflect expectations for the longer input video length. Co-authored-by: AEmotionStudio <163354043+AEmotionStudio@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed
test_speedfailing intests/test_integration.pywhere a 0.2s video processed at 2x speed still evaluated to 0.2s byffprobedue to container and framerate boundaries. Addressed the issue by making the generated test video 1.0s long and adjusting all corresponding integration test duration assertions proportionally.PR created automatically by Jules for task 9897295542523001390 started by @AEmotionStudio