RestartingMgr: Fix SIGNAL_RECURSION_EXIT mismatch#3852
Open
Mrmaxmeier wants to merge 1 commit into
Open
Conversation
SIGNAL_RECURSION_EXIT has always been 101. Exit code 139 is the standard SIGSEGV one. This somehow changed during a refactor commit, not sure what happened there. using the actual SIGNAL_RECURSION_EXIT constant instead of 139 allows `RestartingMgr` to handle cases where the PUT crashes with a SIGSEGV. Without the patch the fuzzer errors out instead of continuing to fuzz.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGNAL_RECURSION_EXIThas always been 101.Exit code 139 is the standard SIGSEGV one.
This somehow changed during a refactor commit (#3612), not sure what happened there. Using the actual
SIGNAL_RECURSION_EXITconstant instead of 139 allowsRestartingMgrto handle cases where the PUT crashes with a SIGSEGV. Without the patch the fuzzer errors out instead of continuing to fuzz.