Added disordered trace grain data to grain_statistics.csv#1376
Open
tobyallwood wants to merge 4 commits into
Open
Added disordered trace grain data to grain_statistics.csv#1376tobyallwood wants to merge 4 commits into
tobyallwood wants to merge 4 commits into
Conversation
8 tasks
SylviaWhittle
approved these changes
Jul 9, 2026
SylviaWhittle
left a comment
SylviaWhittle
left a comment
Collaborator
There was a problem hiding this comment.
Ignoring the failing tests that are a separate issue #1377, I think this is fine to just merge.
No time to do things properly and investigate if this messes with things as was discussed last week in the TopoStats meeting due to other time pressures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TopoStats Pull Requests
Closes #1371
Closes #1372
After the refactor some disordered trace data was collected but never saved to
.csv, this PR rectifies that.Documentation reflecting this has also been updated.
Further changes to the documentation have also been made; these changes are primarily focussed on ensuring the correct
.csvnames are referenced.Before submitting a Pull Request please check the following.