Fix thread safety issues#24
Merged
paulmueller merged 3 commits intoAFM-analysis:masterfrom Apr 15, 2025
Merged
Conversation
Member
|
@kmnhan Thank you! Could you please fix those, then I will merge 🙏 |
Author
|
I've fixed it in aad6c00, could you try running the workflow again? Thanks! |
Member
|
Right, sorry. I'm just going to merge now. No idea why GH Actions did not run.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that trying to load files with a different byte order in different threads leads to a race condition and fails, due to the
PackedFileRecordHeaderobject being global.The following code is a MWE that reproduces the race condition:
This PR ensures thread safety by creating a new instance of the structure for each load instead of reusing the singleton.