Added explicit pathwaysutils.initialize() call to JetStream#233
Conversation
vivianrwu
left a comment
There was a problem hiding this comment.
I think this is less of an "error" and more of "we are running jetstream without pathways. Could we clarify too that this could be intended behavior, or else users may think that there is some failure happening.
2fba2da to
ddf43ec
Compare
Thanks. Updated the log to "Running JetStream without Pathways. Module pathwaysutils is not imported." Please review again. |
vivianrwu
left a comment
There was a problem hiding this comment.
Thanks for the fixes, lgtm!
ddf43ec to
8d385b6
Compare
|
It's weird that it could not pass the checks (pyink format check & test coverage report). I don't see a quick fix due to lack of change suggestions. Shall we bypass the checks? |
pyink you can fix by running |
8d385b6 to
1e2dfad
Compare
|
Thank you. Could you also guide me how to add test coverage for |
You could probably write a test expecting the error. |
b03b5c6 to
b1a70eb
Compare
|
@vipannalla I added the unit test for module engine init. This unit test can pass by running separately |
9fa4fb8 to
596019c
Compare
596019c to
b8c1b7d
Compare
b8c1b7d to
46247f0
Compare
|
Its complaining about unit test coverage for a test file, which should really be excluded from the check. |
Description
pathwaysutils will soon require a call to initialize().
Tests
Depending on GitHub actions for tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):