model_ckpt_conversion: use python module, enable gcloud checkpoint downloading#258
Closed
karan wants to merge 1 commit into
Closed
model_ckpt_conversion: use python module, enable gcloud checkpoint downloading#258karan wants to merge 1 commit into
karan wants to merge 1 commit into
Conversation
vipannalla
approved these changes
Apr 28, 2025
Lumosis
approved these changes
Apr 28, 2025
Collaborator
Author
|
I'm guessing merging from forks doesn't work in this repo either. Could someone help get this one, and in the future I'll send PRs from branches. |
vipannalla
added
the
pull ready
Collaborator
|
Yes, forking is not working for this repo either, and we might not merge manually -- could you restart with branch instead? Thank you! |
Collaborator
Author
|
Ack will do! |
Collaborator
Author
|
@jyj0w0 How can I get access to push to the repo? |
Collaborator
I just invite you to be an writer to this repo |
Collaborator
Author
|
Closing in favor of #261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cb86ae2 seems to have missed
llama_or_mistral_ckpt.GCS copying was commented out in 082c0ac. I'm guessing this was unintended.