MaxCode: Overhaul migration prompts with JAX best practices and MaxText support#26
Open
MaxCode: Overhaul migration prompts with JAX best practices and MaxText support#26
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4 tasks
Rewrites and expands the migration prompt library with: - Comprehensive JAX/Flax best practices (KV cache, causal conv1d, static shapes, attention masking, rotary embeddings, etc.) - Single-file and multi-file conversion prompts - MaxText-specific conversion prompts (YAML overlay, custom layers) - Hallucination prevention rules - Flax scoping and naming conventions Also updates models.py with additional model configuration support. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
772f8c5 to
43d21eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites and significantly expands the migration prompt library (
prompts.py) from ~30 lines to ~800+ lines. The original prompts were minimal instructions; the new prompts encode detailed JAX/Flax best practices, common pitfalls, and conversion rules distilled from iterative testing on real model conversions.What changed in
prompts.pyNew: JAX Best Practices block (14 rules enforced across all prompts)
@nn.compact(notsetup()or NNX)jax.lax.dynamic_update_slice(neverjnp.concatenate)padding="VALID")jax,flax.linen,numpy— no torch)jax.lax.rsqrtsolve_triangularnum_feature_axes)New: Prompt variants
PYTORCH_TO_JAX_SINGLE_FILE_PROMPT— updated with best practicesPYTORCH_TO_JAX_MULTI_FILE_PROMPT— for merged multi-file conversionsUpdated:
models.pyFiles
agents/migration/prompts/prompts.pymodels.pyTest plan
@nn.compact, no torch imports)Split from #17 — PR 4 of 8