Skip to content

Commit dec1690

Browse files
ninatumartinarroyo
andcommitted
Fix: remove unnecessary tensorboard_dir from wan configs
- Address review comments: removed tensorboard_dir because it is created automatically inside the pyconfig. Co-authored-by: martinarroyo <martinarroyo@google.com>
1 parent 7d8fdfb commit dec1690

5 files changed

Lines changed: 0 additions & 5 deletions

File tree

src/maxdiffusion/configs/base_wan_14b.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ diffusion_scheduler_config: {
145145
# Output directory
146146
# Create a GCS bucket, e.g. my-maxtext-outputs and set this to "gs://my-maxtext-outputs/"
147147
base_output_directory: ""
148-
tensorboard_dir: ""
149148

150149
# Hardware
151150
hardware: 'tpu' # Supported hardware types are 'tpu', 'gpu'

src/maxdiffusion/configs/base_wan_1_3b.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ diffusion_scheduler_config: {
122122
# Output directory
123123
# Create a GCS bucket, e.g. my-maxtext-outputs and set this to "gs://my-maxtext-outputs/"
124124
base_output_directory: ""
125-
tensorboard_dir: ""
126125

127126
# Hardware
128127
hardware: 'tpu' # Supported hardware types are 'tpu', 'gpu'

src/maxdiffusion/configs/base_wan_27b.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ diffusion_scheduler_config: {
133133
# Output directory
134134
# Create a GCS bucket, e.g. my-maxtext-outputs and set this to "gs://my-maxtext-outputs/"
135135
base_output_directory: ""
136-
tensorboard_dir: ""
137136

138137
# Hardware
139138
hardware: 'tpu' # Supported hardware types are 'tpu', 'gpu'

src/maxdiffusion/configs/base_wan_i2v_14b.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ diffusion_scheduler_config: {
128128
# Output directory
129129
# Create a GCS bucket, e.g. my-maxtext-outputs and set this to "gs://my-maxtext-outputs/"
130130
base_output_directory: ""
131-
tensorboard_dir: ""
132131

133132
# Hardware
134133
hardware: 'tpu' # Supported hardware types are 'tpu', 'gpu'

src/maxdiffusion/configs/base_wan_i2v_27b.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ diffusion_scheduler_config: {
129129
# Output directory
130130
# Create a GCS bucket, e.g. my-maxtext-outputs and set this to "gs://my-maxtext-outputs/"
131131
base_output_directory: ""
132-
tensorboard_dir: ""
133132

134133
# Hardware
135134
hardware: 'tpu' # Supported hardware types are 'tpu', 'gpu'

0 commit comments

Comments
 (0)