Skip to content

Commit dfe8797

Browse files
committed
Fix apply_rope broadcasting dimensions in attention_flax.py
1 parent 75e2f9e commit dfe8797

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/maxdiffusion/models/attention_flax.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1697,11 +1697,11 @@ def apply_rope(xq: Array, xk: Array, freqs_cis: Any) -> tuple[Array, Array]:
16971697
if isinstance(freqs_cis, (tuple, list)):
16981698
cos, sin = freqs_cis
16991699
if cos.ndim == 2:
1700-
cos = cos[None, None, :, :]
1701-
sin = sin[None, None, :, :]
1700+
cos = cos[None, :, None, :]
1701+
sin = sin[None, :, None, :]
17021702
elif cos.ndim == 3 and cos.shape[0] == 1:
1703-
cos = cos[None, :, :, :]
1704-
sin = sin[None, :, :, :]
1703+
cos = cos[:, :, None, :]
1704+
sin = sin[:, :, None, :]
17051705

17061706
def _rotate(x):
17071707
x_reshaped = x.reshape(*x.shape[:-1], -1, 2)

0 commit comments

Comments
 (0)