Skip to content

Commit 32b5381

Browse files
author
Charles Li
committed
Add log output for jupyter notebooks
1 parent 0529a22 commit 32b5381

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

.github/workflows/run_jupyter_notebooks.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,14 @@ jobs:
7373
# 2. Install MaxText package and all the post training dependencies
7474
uv pip install ${maxtext_wheel}[tpu-post-train] --resolution=lowest
7575
install_tpu_post_train_extra_deps
76-
76+
7777
python3 -m pip freeze
7878
- name: Run Post-Training Notebooks
7979
shell: bash
8080
env:
8181
PYTHONPATH: "${{ github.workspace }}/src"
8282
HF_TOKEN: ${{ secrets.HF_TOKEN }}
83+
MY_HF_TOKEN: ${{ secrets.HF_TOKEN }}
8384
MAXTEXT_INSTALLED: ${{ inputs.maxtext_installed }}
8485
# TODO: Fix evaluation in sft_qwen3_demo.ipynb and remove this env variable
8586
RUN_EVALUATION: "False"
@@ -99,6 +100,9 @@ jobs:
99100
export MAXTEXT_REPO_ROOT=$(pwd)
100101
export MAXTEXT_PKG_DIR=$(pwd)/src/maxtext
101102
export MAXTEXT_NOTEBOOKS_ROOT="$MAXTEXT_REPO_ROOT/src/maxtext/examples"
103+
export HF_TOKEN=${MY_HF_TOKEN}
104+
echo "MY_HF_TOKEN $MY_HF_TOKEN"
105+
echo "HF_TOKEN $HF_TOKEN"
102106
103107
# Register maxtext_venv as a selectable kernel in Jupyter
104108
$PYTHON_EXE -m ipykernel install --user --name maxtext_venv
@@ -116,7 +120,7 @@ jobs:
116120
echo "Running $filename ..."
117121
echo "------------------------------------------------------"
118122
119-
$PAPERMILL_EXE "$notebook" "$output_name" -k maxtext_venv
123+
$PAPERMILL_EXE "$notebook" "$output_name" -k maxtext_venv --log-output --log-level INFO
120124
done
121125
- name: Upload Outputs
122126
if: always()

src/maxtext/examples/sft_llama3_demo_tpu.ipynb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@
117117
"\n",
118118
" # Install uv, a fast Python package installer\n",
119119
" !pip install uv\n",
120-
" \n",
120+
"\n",
121121
" # Install MaxText and post-training dependencies\n",
122122
" !uv pip install -e .[tpu-post-train] --resolution=lowest\n",
123123
" !install_tpu_post_train_extra_deps"
@@ -190,8 +190,10 @@
190190
"try:\n",
191191
" from google.colab import userdata\n",
192192
" HF_TOKEN = userdata.get(\"HF_TOKEN\")\n",
193+
" print(f\"get HF_TOKEN={HF_TOKEN} from google.colab\")\n",
193194
"except ImportError:\n",
194195
" HF_TOKEN = os.environ.get(\"HF_TOKEN\", \"\")\n",
196+
" print(f\"get HF_TOKEN={HF_TOKEN} from env\")\n",
195197
"\n",
196198
"# If not found in the environment, prompt the user for input securely\n",
197199
"# getpass function ensures the token is hidden while you type\n",

0 commit comments

Comments
 (0)