Commit 36e333c
committed
Fix hlo_diff_test to compile the real NNX path
hlo_diff_test loaded each model yml directly as the top-level config, which
skips base.yml and leaves pure_nnx at its pydantic schema default (False), so
the test kept silently compiling the Linen path even after the NNX defaults
were flipped to True in base.yml. Its reference HLOs are therefore still Linen.
Compile via base.yml + model_name (the normal training path) so the config
inherits base.yml's logical_axis_rules and exercises the NNX path. The three
reference HLOs are regenerated for NNX via the Update HLO References workflow.
Also flip the enable_nnx/pure_nnx/pure_nnx_decoder pydantic schema defaults to
True so a config built without base.yml no longer silently falls back to the
Linen path.1 parent 9ce291b commit 36e333c
5 files changed
Lines changed: 5041 additions & 5037 deletions
File tree
- src/maxtext/configs
- tests
- integration
- utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
988 | 988 | | |
989 | 989 | | |
990 | 990 | | |
991 | | - | |
| 991 | + | |
992 | 992 | | |
993 | 993 | | |
994 | | - | |
995 | | - | |
| 994 | + | |
| 995 | + | |
996 | 996 | | |
997 | 997 | | |
998 | 998 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
| 130 | + | |
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
142 | 145 | | |
143 | 146 | | |
144 | 147 | | |
145 | 148 | | |
146 | | - | |
| 149 | + | |
| 150 | + | |
147 | 151 | | |
148 | 152 | | |
149 | 153 | | |
| |||
Large diffs are not rendered by default.
0 commit comments