resolve comments and pylint

Author: YixuanWang-99

src/maxtext/utils/elastic_utils.py

@@ -37,12 +37,11 @@ def record_slice_state(recorder, active_slices_override: int | None = None) -> N
   active_slices = active_slices_override if active_slices_override is not None else len(elastic_manager.active_slice_indices)
   total_slices = len(elastic_manager.slice_to_devices)
 
-  if recorder:
-    recorder.record_elastic_slice_counts(
-        available_slices=available_slices,
-        active_slices=active_slices,
-        total_slices=total_slices
-    )
+  recorder.record_elastic_slice_counts(
+      available_slices=available_slices,
+      active_slices=active_slices,
+      total_slices=total_slices
+  )
 
 def record_elastic_event_start(recorder, config) -> None:
   """Records start of an elastic scale up event."""

tests/unit/elastic_utils_test.py

@@ -108,9 +108,9 @@ def test_record_slice_state(self):
 
     fake_recorder = Mock()
     fake_recorder.record_elastic_slice_counts = Mock()
-    
+
     elastic_utils.record_slice_state(fake_recorder)
-    
+
     fake_recorder.record_elastic_slice_counts.assert_called_once_with(
         available_slices=2,
         active_slices=1,