Skip to content

Commit 6dceda0

Browse files
committed
rename and add initial call
1 parent 6fc5827 commit 6dceda0

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/maxtext/common/goodput.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,9 @@ def create_goodput_recorder(config):
143143
if use_elastic:
144144
try:
145145
from ml_goodput_measurement import goodput_elastic
146-
recorder = goodput_elastic.ElasticGoodputRecorder(config.run_name, logger_name, jax.process_index() == 0)
146+
from maxtext.utils import elastic_utils
147+
recorder = goodput_elastic.ElasticGoodputRecorder(config.run_name, logger_name, jax.process_index() == 0)
148+
elastic_utils.record_slice_state(recorder)
147149
except ImportError:
148150
pass
149151

src/maxtext/utils/elastic_utils.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def record_elastic_event_start(recorder, config) -> None:
4949
event_type = "elastic_scale_up" if is_scale_up_event(config) else "elastic_slice_down"
5050
pending_elastic_event_type = event_type
5151
if recorder:
52-
recorder.record_elastic_wait_start_time(custom_badput_event_type=event_type)
52+
recorder.record_elastic_wait_start_time(event_type=event_type)
5353
record_slice_state(recorder, active_slices_override=0)
5454

5555

@@ -61,8 +61,8 @@ def record_elastic_wait_end_and_reinit_start(recorder) -> None:
6161
event_type = pending_elastic_event_type
6262
pending_elastic_event_type = None
6363
if recorder:
64-
recorder.record_custom_badput_event_end_time(custom_badput_event_type=event_type)
65-
recorder.record_elastic_wait_start_time(custom_badput_event_type='elastic_reinitialization')
64+
recorder.record_elastic_wait_end_time(event_type=event_type)
65+
recorder.record_elastic_reinit_start_time()
6666
record_slice_state(recorder)
6767
pending_reinit_recorder = recorder
6868

@@ -71,9 +71,7 @@ def record_elastic_reinit_end() -> None:
7171
"""Records end of elastic reinitialization event."""
7272
global pending_reinit_recorder
7373
if pending_reinit_recorder is not None:
74-
pending_reinit_recorder.record_custom_badput_event_end_time(
75-
custom_badput_event_type='elastic_reinitialization'
76-
)
74+
pending_reinit_recorder.record_elastic_reinit_end_time()
7775
record_slice_state(pending_reinit_recorder)
7876
pending_reinit_recorder = None
7977

0 commit comments

Comments
 (0)