Skip to content

Commit 70dddd6

Browse files
committed
Temp: Disable XLA_FLAGS forced CPU device count and isolate CPU test suite for fast assertion debugging in CI
1 parent 2997fcf commit 70dddd6

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

.github/workflows/build_and_test_maxtext.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129

130130
maxtext_jupyter_notebooks:
131131
needs: build_and_upload_maxtext_package
132-
if: needs.analyze_code_changes.outputs.run_notebooks == 'true'
132+
if: false
133133
uses: ./.github/workflows/run_jupyter_notebooks.yml
134134
strategy:
135135
fail-fast: false
@@ -145,7 +145,7 @@ jobs:
145145
tpu-tests:
146146
name: ${{ matrix.flavor || 'TPU' }} tests
147147
needs: [build_and_upload_maxtext_package]
148-
if: needs.analyze_code_changes.outputs.run_tests == 'true'
148+
if: false
149149
uses: ./.github/workflows/run_tests_coordinator.yml
150150
strategy:
151151
fail-fast: false
@@ -160,7 +160,7 @@ jobs:
160160
gpu-tests:
161161
name: ${{ matrix.flavor || 'GPU' }} tests
162162
needs: [build_and_upload_maxtext_package]
163-
if: needs.analyze_code_changes.outputs.run_tests == 'true'
163+
if: false
164164
strategy:
165165
fail-fast: false
166166
matrix:
@@ -180,16 +180,17 @@ jobs:
180180
strategy:
181181
fail-fast: false
182182
matrix:
183-
flavor: [cpu-unit, cpu-post-training-unit]
183+
flavor: [cpu-post-training-unit]
184184
with:
185185
flavor: ${{ matrix.flavor }}
186186
base_image: maxtext-unit-test-tpu:py312
187187
is_scheduled_run: ${{ github.event_name == 'schedule' }}
188188
maxtext_sha: ${{ needs.build_and_upload_maxtext_package.outputs.maxtext_sha }}
189+
pytest_extra_args: 'tests/post_training/unit/dpo_trainer_correctness_test.py'
189190

190191
maxtext_tpu_pathways_unit_tests:
191192
needs: build_and_upload_maxtext_package
192-
if: needs.analyze_code_changes.outputs.run_tests == 'true'
193+
if: false
193194
uses: ./.github/workflows/run_pathways_tests.yml
194195
strategy:
195196
fail-fast: false
@@ -208,6 +209,7 @@ jobs:
208209

209210
maxtext_tpu_pathways_integration_tests:
210211
needs: build_and_upload_maxtext_package
212+
if: false
211213
uses: ./.github/workflows/run_pathways_tests.yml
212214
strategy:
213215
fail-fast: false

tests/post_training/integration/dpo_correctness_base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# Force JAX/XLA to only create 1 virtual CPU device to prevent batch size scaling
2222
# issues on large multi-core CI runners (which would cause the 20-example test
2323
# dataset to be dropped completely due to drop_remainder=True).
24-
os.environ["XLA_FLAGS"] = os.environ.get("XLA_FLAGS", "") + " --xla_force_host_platform_device_count=1"
24+
# os.environ["XLA_FLAGS"] = os.environ.get("XLA_FLAGS", "") + " --xla_force_host_platform_device_count=1"
2525

2626
from typing import Any
2727
from absl.testing import parameterized

0 commit comments

Comments
 (0)