Skip to content

Commit 7c7f628

Browse files
Merge pull request #3923 from AI-Hypercomputer:igorts/clean_up_yml_files
PiperOrigin-RevId: 922538927
2 parents a8c4f4d + 75264ef commit 7c7f628

108 files changed

Lines changed: 555 additions & 540 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/build_and_test_maxtext.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ jobs:
119119
needs: analyze_code_changes
120120
# Run if either tests or notebooks need to run
121121
if: |
122-
needs.analyze_code_changes.outputs.run_tests == 'true' ||
122+
needs.analyze_code_changes.outputs.run_tests == 'true' ||
123123
needs.analyze_code_changes.outputs.run_notebooks == 'true'
124124
uses: ./.github/workflows/build_package.yml
125125
with:
@@ -317,4 +317,4 @@ jobs:
317317
actions: 'read'
318318
with:
319319
failed_run_id: '${{ github.run_id }}'
320-
secrets: inherit
320+
secrets: inherit

.github/workflows/gemini-dispatch.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ defaults:
2424
jobs:
2525
debugger:
2626
# Debug mode: with a repository variable called DEBUG to true
27-
if: |-
27+
if: |-
2828
${{ fromJSON(vars.DEBUG || vars.ACTIONS_STEP_DEBUG || false) }}
2929
runs-on: 'ubuntu-latest'
3030
permissions:
@@ -39,7 +39,7 @@ jobs:
3939
DEBUG_event__pull_request__author_association: '${{ github.event.pull_request.author_association }}'
4040
DEBUG_event__review__author_association: '${{ github.event.review.author_association }}'
4141
DEBUG_event: '${{ toJSON(github.event) }}'
42-
run: |-
42+
run: |-
4343
env | grep '^DEBUG_'
4444
4545
dispatch:

.github/workflows/gemini-investigate.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
PR_NUMBER: ${{ github.event.workflow_run.pull_requests[0].number || github.event.pull_request.number || github.event.issue.number }}
3737
run: |
3838
mkdir -p .gemini
39-
39+
4040
# Determine target run ID
4141
if [ -z "$RUN_ID" ]; then
4242
# If SHA/BRANCH are missing (e.g. on issue_comment event), fetch them from PR
@@ -45,22 +45,22 @@ jobs:
4545
SHA=$(gh pr view "$PR_NUMBER" --repo "$REPO" --json headRefOid --jq '.headRefOid' 2>/dev/null || true)
4646
BRANCH=$(gh pr view "$PR_NUMBER" --repo "$REPO" --json headRefName --jq '.headRefName' 2>/dev/null || true)
4747
fi
48-
48+
4949
# Fallback to finding the latest failed run for this PR's specific commit
5050
if [ -n "$SHA" ]; then
5151
echo "Searching for failed runs for commit: $SHA"
5252
RUN_ID=$(gh run list --workflow "MaxText Package Tests" --status failure --commit "$SHA" --limit 1 --json databaseId --jq '.[0].databaseId' --repo "$REPO")
5353
fi
54-
54+
5555
# Fallback to branch if commit-specific run wasn't found
5656
if [ -z "$RUN_ID" ] && [ -n "$BRANCH" ]; then
5757
echo "Searching for failed runs on branch: $BRANCH"
5858
RUN_ID=$(gh run list --workflow "MaxText Package Tests" --status failure --branch "$BRANCH" --limit 1 --json databaseId --jq '.[0].databaseId' --repo "$REPO")
5959
fi
6060
fi
61-
61+
6262
echo "Gathering logs for failed run: $RUN_ID"
63-
63+
6464
if [ -n "$RUN_ID" ]; then
6565
# Retrieve only the failing lines/jobs to avoid token limit overhead
6666
gh run view "$RUN_ID" --log-failed --repo "$REPO" > .gemini/failed_logs.txt || true

.github/workflows/gemini-invoke.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
permission-pull-requests: 'write'
4040

4141
- name: 'Run Gemini CLI'
42-
# Trigger Gemini with context
42+
# Trigger Gemini with context
4343
id: 'run_gemini'
4444
uses: 'google-github-actions/run-gemini-cli@main'
4545
env:

.github/workflows/gemini-review.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
ADDITIONAL_CONTEXT: '${{ inputs.additional_context }}'
6161

6262
- name: 'Run Gemini pull request review'
63-
# reviews code with detailed set of instructions for the Gemini
63+
# reviews code with detailed set of instructions for the Gemini
6464
uses: 'google-github-actions/run-gemini-cli@v0'
6565
id: 'gemini_pr_review'
6666
env:
@@ -71,7 +71,7 @@ jobs:
7171
PULL_REQUEST_NUMBER: '${{ github.event.pull_request.number || github.event.issue.number }}'
7272
REPOSITORY: '${{ github.repository }}'
7373
ADDITIONAL_CONTEXT: '${{ inputs.additional_context }}'
74-
with:
74+
with:
7575
gcp_location: '${{ vars.GOOGLE_CLOUD_LOCATION }}'
7676
gcp_project_id: '${{ vars.GOOGLE_CLOUD_PROJECT }}'
7777
gcp_service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'

.github/workflows/pypi_release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
needs: [release_approval]
4343
uses: ./.github/workflows/build_and_test_maxtext.yml
4444
secrets: inherit
45-
45+
4646
publish_maxtext_package_to_pypi:
4747
name: Publish MaxText package to PyPI
4848
needs: [build_and_test_maxtext_package]

.github/workflows/run_jupyter_notebooks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,15 @@ jobs:
7373
# 2. Install MaxText package and all the post training dependencies
7474
uv pip install ${maxtext_wheel}[tpu-post-train] --resolution=lowest
7575
install_tpu_post_train_extra_deps
76-
76+
7777
python3 -m pip freeze
7878
- name: Run Post-Training Notebooks
7979
shell: bash
8080
env:
8181
HF_TOKEN: ${{ secrets.HF_TOKEN }}
8282
MAXTEXT_INSTALLED: ${{ inputs.maxtext_installed }}
8383
# TODO: Fix evaluation in sft_qwen3_demo.ipynb and remove this env variable
84-
RUN_EVALUATION: "False"
84+
RUN_EVALUATION: "false"
8585
run: |
8686
if [ "${MAXTEXT_INSTALLED}" == "true" ]; then
8787
# Move to the directory where code is baked into the image. See the Dockerfile.

.github/workflows/run_tests_against_package.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ jobs:
8686
TF_FORCE_GPU_ALLOW_GROWTH: ${{ inputs.tf_force_gpu_allow_growth }}
8787
TPU_SKIP_MDS_QUERY: ${{ inputs.device_type == 'cpu' && '1' || '' }}
8888
MAXTEXT_PACKAGE_EXTRA: >-
89-
${{
90-
!contains(inputs.pytest_marker, 'not post_training') && 'tpu-post-train'
91-
|| (inputs.device_type == 'cpu' && 'tpu' || inputs.device_type)
89+
${{
90+
!contains(inputs.pytest_marker, 'not post_training') && 'tpu-post-train'
91+
|| (inputs.device_type == 'cpu' && 'tpu' || inputs.device_type)
9292
}}
9393
ALLOW_MULTIPLE_LIBTPU_LOAD: ${{ inputs.device_type == 'cpu' && 'true' || '' }} # bypass /tmp/libtpu_lockfile check for cpu tests, which don't actually use accelerators (to allow concurrency)
9494
options: ${{ inputs.container_resource_option }}
@@ -177,7 +177,7 @@ jobs:
177177
else
178178
SPLIT_ARGS=""
179179
fi
180-
180+
181181
# Setup substitution: If manually updating HLO, skip tests execution and run only the update script instead!
182182
if [ "${INPUTS_IS_UPDATE_HLO}" == "true" ]; then
183183
python3 tests/utils/update_hlo_references.py

.pre-commit-config.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,9 @@ repos:
6161
additional_dependencies: [mdformat-myst, mdformat-ruff]
6262
files: (docs/.)
6363
exclude: docs/guides/checkpointing_solutions.md|docs/guides.md
64+
65+
- repo: https://github.com/adrienverge/yamllint
66+
rev: v1.35.0
67+
hooks:
68+
- id: yamllint
69+
types: [yaml]

.yamllint

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
extends: relaxed
2+
rules:
3+
line-length: disable
4+
comments: disable
5+
indentation: disable
6+
commas: disable
7+
colons: disable
8+
empty-lines: disable

0 commit comments

Comments
 (0)