Skip to content

Commit 9c83d32

Browse files
committed
resolve comments
1 parent f82653a commit 9c83d32

1 file changed

Lines changed: 7 additions & 12 deletions

File tree

.github/workflows/build_and_test_release_candidate.yml renamed to .github/workflows/release_pipeline.yml

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,32 +15,26 @@
1515
# This workflow will build and test the MaxText package, and build Docker images
1616
# for a Release Candidate when a new release tag is created.
1717

18-
name: Build and Test MaxText Release Candidate
18+
name: MaxText Release Pipeline
1919

20+
# Triggers when a new "release" is published in the GitHub UI
2021
on:
2122
release:
2223
types: [published]
2324
workflow_dispatch:
24-
inputs:
25-
target_device:
26-
description: 'Target Device (tpu, gpu, or all)'
27-
required: false
28-
default: 'all'
29-
type: choice
30-
options:
31-
- all
32-
- tpu
33-
- gpu
3425

3526
permissions:
3627
contents: read
3728
issues: write
29+
id-token: write
3830

3931
jobs:
4032
release_approval:
4133
name: Approve Release Candidate
4234
if: github.event_name != 'workflow_dispatch'
4335
runs-on: ubuntu-latest
36+
# "release" environment is configured in MaxText repository settings.
37+
# This environment requires manual approval before proceeding to the next job.
4438
environment: release
4539
steps:
4640
- name: Acknowledge Approval
@@ -56,7 +50,7 @@ jobs:
5650
secrets: inherit
5751

5852
build_release_candidate_images:
59-
name: Build Release Candidate Images
53+
name: ${{ matrix.image_name }}
6054
needs: [build_and_test_maxtext_package]
6155
if: |
6256
always() &&
@@ -83,5 +77,6 @@ jobs:
8377
workflow: ${{ matrix.workflow }}
8478
dockerfile: ${{ matrix.dockerfile }}
8579
maxtext_sha: ${{ github.sha }}
80+
include_test_assets: true
8681
secrets:
8782
HF_TOKEN: ${{ secrets.HF_TOKEN }}

0 commit comments

Comments
 (0)