Update MaxText Package Tests workflow run conditions

Author: SurbhiJainUSC

.github/workflows/build_and_test_maxtext.yml

@@ -37,8 +37,8 @@ concurrency:
 permissions:
   contents: read
 jobs:
-  doc_only_check:
-    name: Check for Documentation-Only Changes
+  analyze_code_changes:
+    name: Analyze Code Changes for Test Orchestration
     runs-on: ubuntu-latest
     outputs:
       run_tests: ${{ steps.check.outputs.run_tests }}
@@ -47,7 +47,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Check if only documentation changed
+      - name: Check for Code Changes
         id: check
         run: |
           if [ "${{ github.event_name }}" != "pull_request" ]; then
@@ -64,22 +64,49 @@ jobs:
           echo "$CHANGED_FILES"
 
           if [ -z "$CHANGED_FILES" ]; then
-            echo "No files changed"
+            echo "No files detected or diff failed. Running everything as a fail-safe."
             echo "run_tests=true" >> $GITHUB_OUTPUT
             echo "run_notebooks=true" >> $GITHUB_OUTPUT
             exit 0
           fi
 
-          # Check for source code changes (anything not .md and not .ipynb)
+          # default to running everything if something goes wrong with the checks
+          echo "run_tests=true" >> $GITHUB_OUTPUT
+          echo "run_notebooks=true" >> $GITHUB_OUTPUT
+
+          # 1. Check if only documentation files (.md) were changed
+          if ! echo "$CHANGED_FILES" | grep -v -E '\.md$' > /dev/null; then
+            echo "Documentation-only files changed, skipping all tests and notebooks."
+            echo "run_tests=false" >> $GITHUB_OUTPUT
+            echo "run_notebooks=false" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
+          # 2. Check if dependencies or Github workflows were changed
+          if echo "$CHANGED_FILES" | grep -E '(^|/)(src/dependencies/|\.github/workflows/)' > /dev/null; then
+            echo "Core files (dependencies, workflows) changed, enabling all tests and notebooks."
+            echo "run_tests=true" >> $GITHUB_OUTPUT
+            echo "run_notebooks=true" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
+          # 3. Check if post-training files were changed
+          if echo "$CHANGED_FILES" | grep -E 'src/maxtext/trainers/post_train/' > /dev/null; then
+            echo "run_tests=true" >> $GITHUB_OUTPUT
+            echo "run_notebooks=true" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
+          # 4. Check for source code changes (anything not .md and not .ipynb)
           if echo "$CHANGED_FILES" | grep -v -E '\.(md|ipynb)$' > /dev/null; then
-            echo "Source code files changed, enabling unit tests."
+            echo "Source code changed, enabling unit tests."
             echo "run_tests=true" >> $GITHUB_OUTPUT
           else
-            echo "No source code changes, skipping unit tests."
+            echo "No source code changes (only notebook/doc), skipping unit tests."
             echo "run_tests=false" >> $GITHUB_OUTPUT
           fi
 
-          # Check for notebook (.ipynb) changes specifically
+          # 5. Check for notebook (.ipynb) changes
           if echo "$CHANGED_FILES" | grep '\.ipynb$' > /dev/null; then
             echo "Notebook files changed, enabling notebook run."
             echo "run_notebooks=true" >> $GITHUB_OUTPUT
@@ -88,14 +115,12 @@ jobs:
             echo "run_notebooks=false" >> $GITHUB_OUTPUT
           fi
 
-          exit 0
-
   build_and_upload_maxtext_package:
-    needs: doc_only_check
+    needs: analyze_code_changes
     # Run if either tests or notebooks need to run
     if: |
-      needs.doc_only_check.outputs.run_tests == 'true' || 
-      needs.doc_only_check.outputs.run_notebooks == 'true'
+      needs.analyze_code_changes.outputs.run_tests == 'true' || 
+      needs.analyze_code_changes.outputs.run_notebooks == 'true'
     uses: ./.github/workflows/build_package.yml
     with:
       device_type: tpu
@@ -104,7 +129,7 @@ jobs:
 
   maxtext_jupyter_notebooks:
     needs: build_and_upload_maxtext_package
-    if: needs.doc_only_check.outputs.run_notebooks == 'true'
+    if: needs.analyze_code_changes.outputs.run_notebooks == 'true'
     uses: ./.github/workflows/run_jupyter_notebooks.yml
     strategy:
         fail-fast: false
@@ -120,7 +145,7 @@ jobs:
   tpu-tests:
     name: ${{ matrix.flavor }} tests
     needs: [build_and_upload_maxtext_package]
-    if: needs.doc_only_check.outputs.run_tests == 'true'
+    if: needs.analyze_code_changes.outputs.run_tests == 'true'
     uses: ./.github/workflows/run_tests_coordinator.yml
     strategy:
       fail-fast: false
@@ -135,7 +160,7 @@ jobs:
   gpu-tests:
     name: ${{ matrix.flavor }} tests
     needs: [build_and_upload_maxtext_package]
-    if: needs.doc_only_check.outputs.run_tests == 'true'
+    if: needs.analyze_code_changes.outputs.run_tests == 'true'
     strategy:
       fail-fast: false
       matrix:
@@ -150,7 +175,7 @@ jobs:
   cpu-tests:
     name: ${{ matrix.flavor }} tests
     needs: [build_and_upload_maxtext_package]
-    if: needs.doc_only_check.outputs.run_tests == 'true'
+    if: needs.analyze_code_changes.outputs.run_tests == 'true'
     uses: ./.github/workflows/run_tests_coordinator.yml
     strategy:
       fail-fast: false
@@ -164,7 +189,7 @@ jobs:
 
   maxtext_tpu_pathways_unit_tests:
     needs: build_and_upload_maxtext_package
-    if: needs.doc_only_check.outputs.run_tests == 'true'
+    if: needs.analyze_code_changes.outputs.run_tests == 'true'
     uses: ./.github/workflows/run_pathways_tests.yml
     strategy:
         fail-fast: false
@@ -182,7 +207,7 @@ jobs:
 
   maxtext_tpu_pathways_integration_tests:
     needs: build_and_upload_maxtext_package
-    if: needs.doc_only_check.outputs.run_tests == 'true'
+    if: needs.analyze_code_changes.outputs.run_tests == 'true'
     uses: ./.github/workflows/run_pathways_tests.yml
     strategy:
         fail-fast: false
@@ -228,7 +253,7 @@ jobs:
 
           echo "All required tests passed successfully"
         env:
-          NEEDS_DOC_ONLY_CHECK_OUTPUTS_RUN_TESTS: ${{ needs.doc_only_check.outputs.run_tests }}
+          NEEDS_ANALYZE_CODE_CHANGES_OUTPUTS_RUN_TESTS: ${{ needs.analyze_code_changes.outputs.run_tests }}
           NEEDS_BUILD_AND_UPLOAD_MAXTEXT_PACKAGE_RESULT: ${{ needs.build_and_upload_maxtext_package.result }}
           NEEDS_CPU_TESTS_RESULT: ${{ needs.cpu-tests.result }}
           NEEDS_TPU_TESTS_RESULT: ${{ needs.tpu-tests.result }}
@@ -238,13 +263,13 @@ jobs:
 
   all_notebooks_passed:
     name: All Notebooks Passed
-    needs: [doc_only_check, build_and_upload_maxtext_package, maxtext_jupyter_notebooks]
+    needs: [analyze_code_changes, build_and_upload_maxtext_package, maxtext_jupyter_notebooks]
     if: always()
     runs-on: ubuntu-latest
     steps:
       - name: Check notebooks results
         run: |
-          if [ "${NEEDS_DOC_ONLY_CHECK_OUTPUTS_RUN_NOTEBOOKS}" == "false" ]; then
+          if [ "${NEEDS_ANALYZE_CODE_CHANGES_OUTPUTS_RUN_NOTEBOOKS}" == "false" ]; then
             echo "Non-notebook changes detected, runs were skipped"
             exit 0
           fi
@@ -261,7 +286,7 @@ jobs:
 
           echo "All required notebooks passed successfully"
         env:
-          NEEDS_DOC_ONLY_CHECK_OUTPUTS_RUN_NOTEBOOKS: ${{ needs.doc_only_check.outputs.run_notebooks }}
+          NEEDS_ANALYZE_CODE_CHANGES_OUTPUTS_RUN_NOTEBOOKS: ${{ needs.analyze_code_changes.outputs.run_notebooks }}
           NEEDS_BUILD_AND_UPLOAD_MAXTEXT_PACKAGE_RESULT: ${{ needs.build_and_upload_maxtext_package.result }}
           NEEDS_MAXTEXT_JUPYTER_NOTEBOOKS_RESULT: ${{ needs.maxtext_jupyter_notebooks.result }}