Commit a954ff9
Fix ring ragged unsort gradient and clamp local group size.
This change fixes issues in the ragged sort implementation when using ring of experts:
- In `moe.py`, clamp `local_group_size` to `buffer_size` to prevent overflow.
- In `ragged_sort.py`, apply mask to `grad_sorted_tokens` in `_ring_ragged_unsort` backward pass to ensure gradients outside shard boundaries are zeroed out.
- In `ops.py` (megablox), add `group_offset` to `_gmm_fwd` and `_gmm_bwd`.
PiperOrigin-RevId: 9497592271 parent e10af2f commit a954ff9
3 files changed
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| 207 | + | |
207 | 208 | | |
208 | 209 | | |
209 | 210 | | |
| |||
331 | 332 | | |
332 | 333 | | |
333 | 334 | | |
| 335 | + | |
334 | 336 | | |
335 | 337 | | |
336 | 338 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
386 | 386 | | |
387 | 387 | | |
388 | 388 | | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
389 | 393 | | |
390 | 394 | | |
391 | 395 | | |
| |||
405 | 409 | | |
406 | 410 | | |
407 | 411 | | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
408 | 416 | | |
409 | 417 | | |
410 | 418 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
919 | 919 | | |
920 | 920 | | |
921 | 921 | | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
922 | 925 | | |
923 | 926 | | |
924 | 927 | | |
| |||
0 commit comments