Skip to content

Commit b257963

Browse files
Allow Tokamax GMM with pipeline FSDP AG per repeat
1 parent 85690da commit b257963

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

src/maxtext/layers/moe.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1247,10 +1247,7 @@ def jax_ragged_dot_gmm(inputs, kernel, tiling, group_sizes, expert_assignments,
12471247
return output
12481248

12491249
def get_tokamax_group_sizes(group_sizes, inputs, kernel):
1250-
# TODO (b/491979205) pipeline fsdp ag per repeat fails tokamax gmm
1251-
if self.config.use_qwix_quantization or (
1252-
self.config.using_pipeline_parallelism and self.config.pipeline_fsdp_ag_per_repeat
1253-
):
1250+
if self.config.use_qwix_quantization:
12541251
return group_sizes
12551252
elif self.config.attention == "vllm_rpa":
12561253
return group_sizes

0 commit comments

Comments
 (0)