Skip to content

Commit c0b15ef

Browse files
Merge pull request #3299 from CIeNET-International:maxtxt/user/dora/benchmarks_workload_id
PiperOrigin-RevId: 882606227
2 parents f8ea954 + f885131 commit c0b15ef

4 files changed

Lines changed: 4 additions & 0 deletions

File tree

benchmarks/maxtext_xpk_runner.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -746,6 +746,7 @@ def xpk_benchmark_runner(
746746
command, name = generate_xpk_workload_cmd(
747747
cluster_config=cluster_config,
748748
wl_config=wl_config,
749+
workload_name=wl_config.run_name,
749750
user=user,
750751
exp_name=exp_name,
751752
)

benchmarks/recipes/parser_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,3 +156,4 @@ def add_arguments(parser: argparse.ArgumentParser):
156156
parser.add_argument("--delete", action="store_true", help="Delete the cluster workload")
157157
parser.add_argument("--max_restarts", type=int, default=0, help="Maximum number of restarts")
158158
parser.add_argument("--temp_key", type=str, default=None, help="Temporary placeholder code")
159+
parser.add_argument("--workload_id", type=str, default=None, help="Optional custom name for the XPK workload.")

benchmarks/recipes/runner_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def _create_workload_config(
4242
"base_docker_image": (user_config.runner if Framework(framework) == Framework.MCJAX else None),
4343
"pathways_config": (user_config.pathways_config if Framework(framework) == Framework.PATHWAYS else None),
4444
"xpk_path": user_config.xpk_path,
45+
"run_name": user_config.workload_id,
4546
"num_steps": num_steps,
4647
"priority": priority,
4748
"generate_metrics_and_upload_to_big_query": user_config.bq_enable,

benchmarks/recipes/user_configs.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ class UserConfig:
8181
delete: bool = False
8282
max_restarts: int = 0
8383
temp_key: str = None
84+
workload_id: str = None
8485

8586
def __post_init__(self):
8687
"""Automatically generate derived attributes after the object is created."""

0 commit comments

Comments
 (0)