Add has_bos to Jetstream decode request#1692
Merged
Merged
Conversation
vipannalla
approved these changes
May 6, 2025
bvandermoon
approved these changes
May 6, 2025
This reverts commit ebc49030f1790a0ff2a7176586f23c14c3ff51c6.
30b038e to
98ca7a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sets
has_bos=Truein JetStream decode request becausegenerate_distillation_data.pyapplies chat template to the prompt before sending it to JetStream for decoding. Initially, JetStream was hardcodingbostoken to all the prompts before running inference. This was corrupting our results for distillation. PR in JetStream fixes this issue and added a new argument to DecodeRequest proto.Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Tested by running
generate_distillation_data.pyChecklist
Before submitting this PR, please make sure (put X in square brackets):