Deepseek sharding for vLLM and MLA kernel plumbing#3072
Open
khatwanimohit wants to merge 1 commit intomainfrom
Open
Deepseek sharding for vLLM and MLA kernel plumbing#3072khatwanimohit wants to merge 1 commit intomainfrom
khatwanimohit wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
68efcf1 to
4db09ea
Compare
a78bdab to
333f251
Compare
497ba0c to
49ea7f7
Compare
NicoGrande
reviewed
Mar 2, 2026
| num_page_indices = md.block_tables.shape[0] | ||
| assert num_page_indices % max_num_seqs == 0 | ||
| pages_per_seq = num_page_indices // max_num_seqs | ||
| # num_kv_pages_per_block = min(pages_per_seq, 16) |
Collaborator
There was a problem hiding this comment.
Can we get rid of this commented line?
| self.num_query_heads, | ||
| 1, # num_kv_heads for MLA kernel | ||
| self.qk_nope_head_dim, | ||
| q_nope.shape[1], # page size ?? kv_cache.shape[1] |
Collaborator
There was a problem hiding this comment.
Same with this comment.
49ea7f7 to
ce5245e
Compare
ce5245e to
e09523d
Compare
e09523d to
8d91734
Compare
8d91734 to
5a71eb9
Compare
5a71eb9 to
50f9662
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.