Feat/Decoder migration: DeepSeek/Gemma3/Gemma4/Llama4#3114
Draft
hsuan-lun-chiang wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Draft
Feat/Decoder migration: DeepSeek/Gemma3/Gemma4/Llama4#3114hsuan-lun-chiang wants to merge 1 commit intoAI-Hypercomputer:mainfrom
hsuan-lun-chiang wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Conversation
7faa14d to
edbbf29
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
8a3e073 to
2f30ac1
Compare
1a5740b to
5725403
Compare
charlesli640
requested changes
Feb 26, 2026
de4ec11 to
29a9b74
Compare
047b91e to
1d3cc0c
Compare
13cfedf to
d00508e
Compare
40f33b8 to
c4b5e64
Compare
80ebfcb to
f0ddf63
Compare
e1bc3f2 to
21fd4f5
Compare
06657a2 to
53f3052
Compare
Collaborator
|
Thanks for the change! Before the review, could you ensure those are tested? Thank you! |
Collaborator
Author
Hi @RissyRan, the Linen/NNX comparison logs for Llama4/Deepseek/Gemma4 are in the GDoc file. The PR is passing all unit tests with NNX flags (enable_nnx=True and pure_nnx_decoder=True), except for a few cases requiring further discussion, which we’ve documented here. Would you mind taking a look? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement and update the following models in NNX decoder that were are not supported in previous PR 2831:
Tests
Test with different model and compare with Linen training. Details in the GDoc file
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.