PR #3359: Make Docker build and upload scripts runnable through pip#3380
Merged
2 commits merged intomainfrom Mar 11, 2026
Merged
PR #3359: Make Docker build and upload scripts runnable through pip#33802 commits merged intomainfrom
2 commits merged intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
PiperOrigin-RevId: 882138382
19ae7f4 to
d561ad4
Compare
d561ad4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3359: Make Docker build and upload scripts runnable through pip
Imported from GitHub PR #3359
Description
/dependenciesdirectory tosrc/dependencies. This allows the docker build/upload scripts to be included in the pip packagedocker_build_dependency_image.shanddocker_upload_runner.shpyproject.tomlfor these Python wrappers. This lets users run these scripts directly after pip installing MaxTextNext steps:
pyproject.tomlso users can run these scripts without installing unecessary dependenciesNote: This changes the location the script is run from. We will update existing references we find and notify as many users as we can
FIXES: b/490520594
Tests
Setup with
uv pip install -e .[tpu] --resolution=lowestBuilt stable image through pip script + bash:
Built nightly image:
Ran successful workload for both builds with:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.Copybara import of the project:
--
6ad79a9 by Branden Vandermoon bvandermoon@google.com:
Make Docker build and upload scripts runnable through pip
Merging this change closes #3359
FUTURE_COPYBARA_INTEGRATE_REVIEW=#3359 from AI-Hypercomputer:bvandermoon-docker-builds 6ad79a9