Skip to content

Add unit test for prompt filtering#3399

Merged
copybara-service[bot] merged 1 commit intomainfrom
igorts/b490410764-prompt-filter-test
Mar 17, 2026
Merged

Add unit test for prompt filtering#3399
copybara-service[bot] merged 1 commit intomainfrom
igorts/b490410764-prompt-filter-test

Conversation

@igorts-git
Copy link
Copy Markdown
Collaborator

@igorts-git igorts-git commented Mar 12, 2026

Description

Add unit tests to the long sequence filtering logic.

FIXES: b/490410764

Tests

Added unit tests to the new logic.
CI.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@igorts-git igorts-git marked this pull request as ready for review March 12, 2026 17:07
@igorts-git igorts-git changed the title Refactor rl_train and add unit test for prompt filtering and Refactor rl_train and add unit test for prompt filtering Mar 12, 2026
@igorts-git igorts-git force-pushed the igorts/b490410764-prompt-filter-test branch from 6513acd to bd6e94f Compare March 16, 2026 22:14
@igorts-git igorts-git changed the title Refactor rl_train and add unit test for prompt filtering Add unit test for prompt filtering Mar 16, 2026
Copy link
Copy Markdown
Collaborator

@xuefgu xuefgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Igor!

@igorts-git igorts-git force-pushed the igorts/b490410764-prompt-filter-test branch from bd6e94f to b2eb6e3 Compare March 17, 2026 17:05
@copybara-service copybara-service Bot merged commit 6e47e57 into main Mar 17, 2026
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants