Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
fa1d7e7 to
735732b
Compare
vlad-karp
approved these changes
Mar 17, 2026
PiperOrigin-RevId: 885217977
PiperOrigin-RevId: 885251295
PiperOrigin-RevId: 885324693
…r/maxtext into optimizer_ga_fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the amount of optimizer steps that are set when using gradient accumulation with optax.MultiStep.
By using student_config.steps, we ensure that the maxtext optimizer, lr_scheduler and optax.MultiStep stay in sync with the difference being how many backward passes are performed based on gradient_accumulation. Ex:
The number of samples seen by the model stay exactly the same.
Tests
Ran:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.