Move install_maxtext_extra_deps to dependencies directory#3449
Closed
bvandermoon wants to merge 1 commit intomainfrom
Closed
Move install_maxtext_extra_deps to dependencies directory#3449bvandermoon wants to merge 1 commit intomainfrom
bvandermoon wants to merge 1 commit intomainfrom
Conversation
bvandermoon
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jacoguzo,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
force-pushed
the
bvandermoon-github-deps
branch
from
cc6aea2 to
6d2da4f
Compare
SurbhiJainUSC
approved these changes
Mar 19, 2026
bvandermoon
force-pushed
the
bvandermoon-github-deps
branch
from
6d2da4f to
277b08e
Compare
NuojCheng
approved these changes
Mar 19, 2026
dipannita08
approved these changes
Mar 19, 2026
bvandermoon
force-pushed
the
bvandermoon-github-deps
branch
from
277b08e to
c2451ec
Compare
Shuwen-Fang
pushed a commit
that referenced
this pull request
Mar 25, 2026
Imported from GitHub PR #3449 Move the `install_maxtext_extra_deps` deps directory to `dependencies` after `dependencies` was added to the PyPI package. This command still works/runs the expected installation: ``` uv pip install -e .[tpu] --resolution=lowest install_maxtext_tpu_github_deps install_maxtext_tpu_post_train_extra_deps ``` CI also builds this command Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation. Copybara import of the project: -- 277b08e by Branden Vandermoon <bvandermoon@google.com>: Move install_maxtext_extra_deps to dependencies directory Merging this change closes #3449 COPYBARA_INTEGRATE_REVIEW=#3449 from AI-Hypercomputer:bvandermoon-github-deps 277b08e PiperOrigin-RevId: 886463160
Shuwen-Fang
pushed a commit
that referenced
this pull request
Mar 25, 2026
Imported from GitHub PR #3449 Move the `install_maxtext_extra_deps` deps directory to `dependencies` after `dependencies` was added to the PyPI package. This command still works/runs the expected installation: ``` uv pip install -e .[tpu] --resolution=lowest install_maxtext_tpu_github_deps install_maxtext_tpu_post_train_extra_deps ``` CI also builds this command Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation. Copybara import of the project: -- 277b08e by Branden Vandermoon <bvandermoon@google.com>: Move install_maxtext_extra_deps to dependencies directory Merging this change closes #3449 COPYBARA_INTEGRATE_REVIEW=#3449 from AI-Hypercomputer:bvandermoon-github-deps 277b08e PiperOrigin-RevId: 886463160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the
install_maxtext_extra_depsdeps directory todependenciesafterdependencieswas added to the PyPI package.Tests
This command still works/runs the expected installation:
CI also builds this command
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.