Skip to content

fix optimizer number of steps#3452

Merged
copybara-service[bot] merged 1 commit intomainfrom
optimizer_ga_fix_2
Mar 20, 2026
Merged

fix optimizer number of steps#3452
copybara-service[bot] merged 1 commit intomainfrom
optimizer_ga_fix_2

Conversation

@entrpn
Copy link
Copy Markdown
Collaborator

@entrpn entrpn commented Mar 18, 2026

Description

Fixes the amount of optimizer steps that are set when using gradient accumulation with optax.MultiStep.

By using student_config.steps, we ensure that the maxtext optimizer, lr_scheduler and optax.MultiStep stay in sync with the difference being how many backward passes are performed based on gradient_accumulation. Ex:

  • ga=1, 5k steps, will do 5k backward passes.
  • ga=2, 5k steps, will do 5k/2 backward passes.

The number of samples seen by the model stay exactly the same.

Tests

Ran:

  • tests.unit.distillation_checkpointing_test
  • tests.unit.train_distill_test

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../trainers/post_train/distillation/train_distill.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@copybara-service copybara-service Bot merged commit 1a45bf0 into main Mar 20, 2026
56 of 59 checks passed
@copybara-service copybara-service Bot deleted the optimizer_ga_fix_2 branch March 20, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants