Skip to content

add batch split config#3497

Merged
copybara-service[bot] merged 2 commits intomainfrom
qinwen/add_batch_split
Mar 26, 2026
Merged

add batch split config#3497
copybara-service[bot] merged 2 commits intomainfrom
qinwen/add_batch_split

Conversation

@suexu1025
Copy link
Copy Markdown
Collaborator

@suexu1025 suexu1025 commented Mar 25, 2026 •
edited
Loading

Description

  1. Added new config for deepseek batch split

  2. Test:
    cloudlog

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

RissyRan
RissyRan approved these changes Mar 25, 2026
View reviewed changes
Comment thread src/maxtext/configs/models/deepseek3-671b-batchsplit.yml Outdated
NuojCheng
NuojCheng reviewed Mar 25, 2026
View reviewed changes
Comment thread src/maxtext/configs/models/deepseek3-671b-batchsplit.yml
@suexu1025
add batch split config
d09111e 
update

format

Update deepseek3-671b-batchsplit.yml

update year
@suexu1025 suexu1025 force-pushed the qinwen/add_batch_split branch from c99628b to d09111e Compare March 25, 2026 22:14
@copybara-service copybara-service Bot merged commit aeb7510 into main Mar 26, 2026
24 checks passed
@copybara-service copybara-service Bot deleted the qinwen/add_batch_split branch March 26, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuningjin shuningjin shuningjin approved these changes

@RissyRan RissyRan RissyRan approved these changes

@NuojCheng NuojCheng NuojCheng approved these changes

@parambole parambole Awaiting requested review from parambole parambole is a code owner

@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@NicoGrande NicoGrande Awaiting requested review from NicoGrande NicoGrande is a code owner

@jesselu-google jesselu-google Awaiting requested review from jesselu-google jesselu-google is a code owner

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner

@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner

@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 is a code owner

@igorts-git igorts-git Awaiting requested review from igorts-git igorts-git is a code owner

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suexu1025 @RissyRan @shuningjin @NuojCheng