Skip to content

Fix the gradients' device memory space when enabling parameter offloading #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 26, 2026
+8 −1
Merged

Fix the gradients' device memory space when enabling parameter offloading #3503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/maxtext/trainers/pre_train/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,11 @@ def train_step(model, config, state_mesh_shardings, params_shardings, state, dat
lambda x: x.astype(config.grad_dtype) if x.dtype == jnp.float32 else x,
raw_grads,
)
if config.parameter_memory_host_offload:
raw_grads = jax.device_put(
raw_grads,
max_utils.with_memory_kind(params_shardings, "device"),
)
intermediate_outputs = aux["intermediate_outputs"]
total_weights = aux["total_weights"]
moe_lb_loss = aux["moe_lb_loss"]
Expand Down
4 changes: 3 additions & 1 deletion src/maxtext/utils/max_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import time
from typing import Any

from packaging.version import Version

from etils import epath
import flax
import jax
Expand Down Expand Up @@ -82,7 +84,7 @@ def calculate_num_params_from_pytree(params):
def device_space():
"""Version guard for jax.memory.Space.Device."""
# See b/436565838 for more.
if jax.__version__ >= "0.7.1":
if Version(jax.__version__) >= Version("0.7.1"):
return jax.memory.Space.Device # pytype: disable=module-attr
else:
return jax._src.sharding_impls.TransferToMemoryKind("device") # pylint: disable=protected-access # pytype: disable=module-attr
Expand Down
Loading