Add open-r1/OpenR1-Math-220k and bethgelab/CuratedThoughts datasets to RL#3509
Closed
SurbhiJainUSC wants to merge 16 commits intomainfrom
Closed
Add open-r1/OpenR1-Math-220k and bethgelab/CuratedThoughts datasets to RL#3509SurbhiJainUSC wants to merge 16 commits intomainfrom
SurbhiJainUSC wants to merge 16 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
6ec6d77 to
dbd0cd4
Compare
dbd0cd4 to
cf8d567
Compare
cf8d567 to
2f74c84
Compare
…ctness datasetname, add MATH-500 to preprocess_math_string
A9isha
reviewed
Apr 9, 2026
Collaborator
A9isha
left a comment
There was a problem hiding this comment.
Let's remember to add the condition that even if the dataset_name and eval_dataset_name are same, we need to check if the splits are also the same - and only then do a split of the dataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
prepare_openinstructmath2_dataset()toprepare_train_and_eval_dataset()to handle multiple datasets generically.process_data()to find questions and answers across various keys (e.g., "problem", "prompt", "solution", "expected_answer").process_answer()andprocess_mcq()to parse MCQ options directly from the question text.check_answer()reward function and simplified reward by overlapping it withcheck_numbers().math_verify_func()would fail during training because the underlying Math-Verify 'parse' function usessignal.alarm(), which is incompatible with threaded environments. Implemented a manual math verification function with a 5-second timeout, ensuring it can run safely in a multithreaded context.normalize_final_answer()to handle mixed numbers (e.g., converting"3 \frac{1}{2}"to"3+\frac{1}{2}").Tests
Tested on
v5p-8:Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.