Skip to content

PR #3501: DO NOT MERGE Clean check vma#3532

Closed
Shuwen-Fang wants to merge 1 commit intomainfrom
test_889398062
Closed

PR #3501: DO NOT MERGE Clean check vma#3532
Shuwen-Fang wants to merge 1 commit intomainfrom
test_889398062

Conversation

@Shuwen-Fang
Copy link
Copy Markdown
Collaborator

PR #3501: DO NOT MERGE Clean check vma

Imported from GitHub PR #3501

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Copybara import of the project:

--
ec1b98b by Shuwen Fang shuwenf@google.com:

moe formatting changes

--
7618024 by Shuwen Fang shuwenf@google.com:

check vma changes

--
41b53c9 by Shuwen Fang shuwenf@google.com:

check vma changes

Merging this change closes #3501

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3501 from AI-Hypercomputer:clean-check-vma 41b53c9

Imported from GitHub PR #3501

# Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:
- why is this change being made,
- the problem being solved and any relevant context,
- why this is a good solution,
- some information about the specific implementation,
- shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

*Notice 1:* Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.

*Notice 2:* For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

# Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

# Checklist

Before submitting this PR, please make sure (put X in square brackets):
- [ ] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label.
- [ ] I have necessary comments in my code, particularly in hard-to-understand areas.
- [ ] I have run end-to-end tests tests and provided workload links above if applicable.
- [ ] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files).

Copybara import of the project:

--
ec1b98b by Shuwen Fang <shuwenf@google.com>:

moe formatting changes

--
7618024 by Shuwen Fang <shuwenf@google.com>:

check vma changes

--
41b53c9 by Shuwen Fang <shuwenf@google.com>:

check vma changes

Merging this change closes #3501

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3501 from AI-Hypercomputer:clean-check-vma 41b53c9
PiperOrigin-RevId: 889398062
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/moe.py 6.66% 14 Missing ⚠️
src/maxtext/kernels/megablox/ops.py 0.00% 6 Missing ⚠️
src/maxtext/utils/gradient_accumulation.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@copybara-service copybara-service Bot closed this Apr 2, 2026
@copybara-service copybara-service Bot deleted the test_889398062 branch April 2, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant