PR #3501: DO NOT MERGE Clean check vma#3532
Closed
Shuwen-Fang wants to merge 1 commit intomainfrom
Closed
Conversation
ce40301 to
b6dc0fc
Compare
Imported from GitHub PR #3501 # Description Start with a short description of what the PR does and how this is a change from the past. The rest of the description includes relevant details and context, examples: - why is this change being made, - the problem being solved and any relevant context, - why this is a good solution, - some information about the specific implementation, - shortcomings of the solution and possible future improvements. If the change fixes a bug or a Github issue, please include a link, e.g.,: FIXES: b/123456 FIXES: #123456 *Notice 1:* Once all tests pass, the "pull ready" label will automatically be assigned. This label is used for administrative purposes. Please do not add it manually. *Notice 2:* For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests. # Tests Please describe how you tested this change, and include any instructions and/or commands to reproduce. # Checklist Before submitting this PR, please make sure (put X in square brackets): - [ ] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [ ] I have necessary comments in my code, particularly in hard-to-understand areas. - [ ] I have run end-to-end tests tests and provided workload links above if applicable. - [ ] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- ec1b98b by Shuwen Fang <shuwenf@google.com>: moe formatting changes -- 7618024 by Shuwen Fang <shuwenf@google.com>: check vma changes -- 41b53c9 by Shuwen Fang <shuwenf@google.com>: check vma changes Merging this change closes #3501 FUTURE_COPYBARA_INTEGRATE_REVIEW=#3501 from AI-Hypercomputer:clean-check-vma 41b53c9 PiperOrigin-RevId: 889398062
b6dc0fc to
fbb59f6
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3501: DO NOT MERGE Clean check vma
Imported from GitHub PR #3501
Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.Copybara import of the project:
--
ec1b98b by Shuwen Fang shuwenf@google.com:
moe formatting changes
--
7618024 by Shuwen Fang shuwenf@google.com:
check vma changes
--
41b53c9 by Shuwen Fang shuwenf@google.com:
check vma changes
Merging this change closes #3501
FUTURE_COPYBARA_INTEGRATE_REVIEW=#3501 from AI-Hypercomputer:clean-check-vma 41b53c9