Skip to content

Update config correcting rule and log_config#3645

Merged
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-correct-logical
Apr 11, 2026
Merged

Update config correcting rule and log_config#3645
copybara-service[bot] merged 1 commit intomainfrom
chengnuojin-correct-logical

Conversation

@NuojCheng
Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng commented Apr 11, 2026

Description

Update activation_kv_batch in logical rule to include expert and correct log_config as True.

Tests

This PR successfully recover ds2 performance back to ~80TFLOPs/s, see https://paste.googleplex.com/5815349401485312.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM! Please ensure running tests are passing. Thank you!

@copybara-service copybara-service Bot merged commit c73595a into main Apr 11, 2026
46 of 47 checks passed
@copybara-service copybara-service Bot deleted the chengnuojin-correct-logical branch April 11, 2026 22:05
@NuojCheng NuojCheng mentioned this pull request Apr 13, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants