Skip to content

Add unit tests for param_mapping.py#3711

Open
bvandermoon wants to merge 1 commit intomainfrom
bvandermoon-param-mapping-tests
Open

Add unit tests for param_mapping.py#3711
bvandermoon wants to merge 1 commit intomainfrom
bvandermoon-param-mapping-tests

Conversation

@bvandermoon
Copy link
Copy Markdown
Collaborator

@bvandermoon bvandermoon commented Apr 21, 2026

Description

This PR adds unit tests for param_mapping.py to increase code coverage. This change introduces tests for mapping and hook functions across various models (Gemma, Qwen, DeepSeek, etc.) and configurations (scanned vs unscanned layers).

Tests

Tested by running pytest on a TPU VM with coverage enabled:

pytest --cov=src/maxtext/checkpoint_conversion/utils tests/unit/param_mapping_test.py

Checklist

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@bvandermoon bvandermoon force-pushed the bvandermoon-param-mapping-tests branch 2 times, most recently from 6e8d1d2 to ff17127 Compare April 21, 2026 20:39
@bvandermoon bvandermoon force-pushed the bvandermoon-param-mapping-tests branch 3 times, most recently from 5f81bf3 to 4db6d41 Compare April 21, 2026 23:41
@bvandermoon bvandermoon force-pushed the bvandermoon-param-mapping-tests branch from 4db6d41 to 6655116 Compare April 21, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants