Open
Conversation
NuojCheng
requested review from
A9isha,
NicoGrande,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NuojCheng
force-pushed
the
chengnuojin-vllm-rule-update
branch
from
ad39294 to
92cc4b5
Compare
4 tasks
NuojCheng
force-pushed
the
chengnuojin-vllm-rule-update
branch
from
92cc4b5 to
9e3afc1
Compare
gobbleturk
reviewed
Apr 22, 2026
|
|
||
| with self.mesh, nn.logical_axis_rules(self.maxtext_config.logical_axis_rules): | ||
| model, _ = model_creation_utils.create_nnx_model( | ||
| model = model_creation_utils.from_pretrained( |
Collaborator
There was a problem hiding this comment.
why is this part of the PR? Is this some artifact of rebasing?
Collaborator
Author
There was a problem hiding this comment.
not from rebasing but vllm decoding fails at head now. Put in the same PR for decoding test purpose.
Collaborator
There was a problem hiding this comment.
Mind adding this info to the PR description?
Collaborator
Author
There was a problem hiding this comment.
Mind adding this info to the PR description?
Done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It refactor the vllm logical rule and enable attn dp expert for optimal inference performance.
This PR also updates the function names from
create_nnx_modeltofrom_pretrainedfollowing updates from #3450 .Tests
Vllm test: https://paste.googleplex.com/4812933185011712
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.