Track lower-case maxtext package in coverage to unblock Codecov#3724
Open
ecnal-cienet wants to merge 1 commit intomainfrom
Open
Track lower-case maxtext package in coverage to unblock Codecov#3724ecnal-cienet wants to merge 1 commit intomainfrom
ecnal-cienet wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ecnal-cienet
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
The NNX-migrated code lives in src/maxtext/ (lower-case) but .coveragerc only listed the upper-case MaxText package in [run] source. coverage.py therefore never instrumented the new files, so added lines showed up on Codecov with no coverage data and suppressed patch coverage. The existing [paths] aliasing only merges already-collected data across filesystems; it does not control what is traced in the first place.
ecnal-cienet
force-pushed
the
fix/coveragerc-track-lowercase-maxtext
branch
from
5ad8163 to
b60f515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxtext(lower-case) to[run] sourcein.coveragercalongsideMaxText(upper-case).Why
coverage.pyuses[run] sourceto decide which packages to trace. The config previously listed onlyMaxText, so files imported via the lower-casemaxtextpackage (the NNX-migrated path atsrc/maxtext/) were never instrumented. Lines covered by real unit tests therefore showed up on Codecov asnullrather thanhit, pushing patch coverage artificially low.The existing
[paths]aliasing only merges already-collected measurements across filesystems — it does not control what is traced in the first place.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.