Open
Conversation
aireenmei
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
bvandermoon,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NuojCheng
reviewed
Apr 22, 2026
| @@ -228,6 +228,8 @@ def _bwd_scan_body(grad_params_acc, chunk_data): | |||
| # grad_params = jax.tree_util.tree_map(lambda x, y: y.astype(x.dtype), gathered_params, grad_params) | |||
Collaborator
There was a problem hiding this comment.
could you remove the comments in line 227 and 228?
Collaborator
Author
There was a problem hiding this comment.
Cleaned the comments as discussed offline
NuojCheng
approved these changes
Apr 22, 2026
Collaborator
NuojCheng
left a comment
NuojCheng
left a comment
There was a problem hiding this comment.
thank you for the fix!
gobbleturk
reviewed
Apr 22, 2026
Collaborator
gobbleturk
left a comment
gobbleturk
left a comment
There was a problem hiding this comment.
Is there a compile test using vocab tiling that should have caught this? Can we add some test protecting this?
aireenmei
force-pushed
the
aireen/vocab_dtype
branch
from
e8d8140 to
a912927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix this error when testing gemma4 with bfloat16 and
num_vocab_tiling=8Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.