Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NicoGrande
approved these changes
Apr 23, 2026
a644300 to
22cfdb5
Compare
22cfdb5 to
6ce6ef6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tile sizes for megablox were being passed / being named inappropriately. E.g. before we were passing in wi_dlhs_embed as the fourth argument, but that will map to "k" of the dlhs which will actually be the model dimension.
Note this PR has the effect of mapping/permuting the tile sizes. You can see in existing tuned tile sizes like here the optimal wi_mlp_dim is actually related to the embed dim, not the mlp dim
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.