Skip to content

Fix megablox tile sizes#3731

Open
gobbleturk wants to merge 1 commit intomainfrom
mattdavidow-fix-tile-head
Open

Fix megablox tile sizes#3731
gobbleturk wants to merge 1 commit intomainfrom
mattdavidow-fix-tile-head

Conversation

@gobbleturk
Copy link
Copy Markdown
Collaborator

@gobbleturk gobbleturk commented Apr 23, 2026

Description

Tile sizes for megablox were being passed / being named inappropriately. E.g. before we were passing in wi_dlhs_embed as the fourth argument, but that will map to "k" of the dlhs which will actually be the model dimension.

Note this PR has the effect of mapping/permuting the tile sizes. You can see in existing tuned tile sizes like here the optimal wi_mlp_dim is actually related to the embed dim, not the mlp dim

Tests

  • test irregular model shapes and tile sizes that batch command
  • xprof (~66% MFU on gmms)

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gobbleturk gobbleturk force-pushed the mattdavidow-fix-tile-head branch from a644300 to 22cfdb5 Compare April 23, 2026 01:01
@gobbleturk gobbleturk force-pushed the mattdavidow-fix-tile-head branch from 22cfdb5 to 6ce6ef6 Compare April 23, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants